Github user tgravescs commented on the pull request:
https://github.com/apache/spark/pull/12152#issuecomment-206527111
So to me here the difference is shell scripts vs Java code. Unless you
know of an easier way with antrun to do the md5sum and get the git information?
All I really saw was the exec option to call out to shell.
I would rather maintain java code then shell scripts. Generally the java
code should be easier to maintain and less brittle.
I don't see why having our own maven plugin for this is such a big deal, it
means we can do whatever we want with it but at the same times other apache
projects basically use the same plugin and its known to work and shouldn't
really change unless we decide to add something to it. Why is a maven plugin
any different for core code that we write from scratch? maven provide
utilities for writing your own plugins, I don't see that breaking. We can
remove the svn stuff from it and it will shrink the actual code size.
We do have to handle it in sbt, but as I said above personally I think we
could simply echo out a properties file with just the version and leave the
other fields empty since its just for developer builds.
@JoshRosen you made a comment about this being to complex, what were you
thinking or proposing as alternative? And why is this to complex?
Perhaps the difference here is the jira should have been more detailed to
list out all of the things we wanted to get here rather then just the version.
I'd be alright with removing the md5sum if we don't want that, but I think the
rest of the information is really useful for tracability. It makes it easy to
look at a jar running on a cluster and see who built it, from what repo and
commit, and what is the specific version.
Also note that this pr has 25 files changed but the majority of them are
really small just switching to use VersionInfo.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
