Github user vanzin commented on the pull request:

    https://github.com/apache/spark/pull/12209#issuecomment-207047304
  
    Adding the assembly to the classpath that way means the newer protobuf will 
override any older version on the Spark jars. So kinesis will work, but any 
code in Spark that is not compatible with the new protobuf will fail. It sounds 
a little risk.
    
    Doing relocation in the kinesis assembly should be pretty straight forward. 
Here's an example from Spark's own build: 
https://github.com/apache/spark/blob/master/pom.xml#L2207


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to