GitHub user dongjoon-hyun opened a pull request:
https://github.com/apache/spark/pull/12242
[SPARK-14465][BUILD] Checkstyle should check all Java files
## What changes were proposed in this pull request?
Currently, `checkstyle` is configured to check the files under
`src/main/java`. However, Spark has Java files in `src/main/scala`, too. This
PR fixes the following configuration in `pom.xml` and the unchecked-so-far
violations on those files.
```xml
-<sourceDirectory>${basedir}/src/main/java</sourceDirectory>
+<sourceDirectories>${basedir}/src/main/java,${basedir}/src/main/scala</sourceDirectories>
```
## How was this patch tested?
After passing the Jenkins build and manually `dev/lint-java`. (Note that
Jenkins does not run `lint-java`)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dongjoon-hyun/spark SPARK-14465
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/12242.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #12242
----
commit aaf19f976632b1b0b9e40c0dd33d6b556504b48d
Author: Dongjoon Hyun <[email protected]>
Date: 2016-04-07T20:29:52Z
[SPARK-14465][BUILD] Checkstyle should check all Java files
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
