Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12228#discussion_r59009601
--- Diff: core/src/main/scala/org/apache/spark/executor/Executor.scala ---
@@ -321,7 +321,7 @@ private[spark] class Executor(
logInfo(s"Executor killed $taskName (TID $taskId)")
execBackend.statusUpdate(taskId, TaskState.KILLED,
ser.serialize(TaskKilled))
- case cDE: CommitDeniedException =>
+ case CausedBy(cDE: CommitDeniedException) =>
--- End diff --
It's tidy, but seems like overkill if this is the only place in the code
that checks if "T, or its immediate cause, is a FooException". `case t:
Throwable if t.getCause.isInstanceOf[CommitDeniedException] =>` is sufficient
to handle the additional case, at the cost of repeating the line of code.
Alternatively, if there are really a few instances of this pattern in the
code that we can clean up with this pattern, then it seems worthwhile.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
