Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12241#discussion_r59080184
  
    --- Diff: dev/sparktestsupport/modules.py ---
    @@ -256,9 +256,21 @@ def __hash__(self):
     )
     
     
    +mllib_local = Module(
    +    name="mllib-local",
    +    dependencies=[sketch],
    --- End diff --
    
    It doesn't belong in either sketch or mllib-local really. Since the purpose 
is to dissociate from spark-core, you should probably make a new exception type 
or examine whether generic exception types can be used instead.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to