Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/12200#issuecomment-207628271
This LGTM
For defaults, if the Param applies to training only (like minDF), then it
makes sense to set the default in the Estimator. But if the Param applies to
transforming as well (like minTF), then it's good to set the default in the
base trait so it applies to the Estimator and Model. So the current status
looks good to me.
@MLnick Please merge if this looks good to you now
Thanks all!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
