Github user mengxr commented on the pull request:

    https://github.com/apache/spark/pull/12062#issuecomment-207828145
  
    @zhengruifeng 
    
    * Please try making each PR minimal. For example, this PR could be split 
into two PRs, one for LDA and one for StreamingKMeans.
    * Create a JIRA for non-trivial changes. This PR requires 
`checkpoingInterval >= -1`, which might affect existing user code unless we 
know that for any value `< -1` there would be an error, just at a later time. 
However, this is not apparent.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to