Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12280#discussion_r59125547
--- Diff:
external/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisRecordProcessor.scala
---
@@ -148,29 +147,25 @@ private[kinesis] object KinesisRecordProcessor
extends Logging {
/* If the function failed, either retry or throw the exception */
case util.Failure(e) => e match {
/* Retry: Throttling or other Retryable exception has occurred */
- case _: ThrottlingException | _:
KinesisClientLibDependencyException if numRetriesLeft > 1
- => {
- val backOffMillis = Random.nextInt(maxBackOffMillis)
- Thread.sleep(backOffMillis)
- logError(s"Retryable Exception: Random
backOffMillis=${backOffMillis}", e)
- retryRandom(expression, numRetriesLeft - 1,
maxBackOffMillis)
- }
+ case _: ThrottlingException | _:
KinesisClientLibDependencyException
+ if numRetriesLeft > 1 =>
--- End diff --
Does this not fit on the previous line? if it can squeeze in it's clearer
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
