Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/12267#discussion_r59156961
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -787,6 +788,28 @@ object BooleanSimplification extends Rule[LogicalPlan]
with PredicateHelper {
}
/**
+ * Simplifies semantically-equal non-nullable expressions:
+ * 1) Replace '=', '<=', and '>=' with 'true' literal
+ * 2) Replace '<' and '>' with 'false' literal
+ */
+object NonNullableBinaryComparisonSimplification extends Rule[LogicalPlan]
with PredicateHelper {
+ def apply(plan: LogicalPlan): LogicalPlan = plan transform {
+ case q: LogicalPlan => q transformExpressionsUp {
+ // True with equality
+ case a EqualTo b if !a.nullable && !b.nullable &&
a.semanticEquals(b) => TrueLiteral
+ case a EqualNullSafe b if !a.nullable && !b.nullable &&
a.semanticEquals(b) => TrueLiteral
--- End diff --
The javadoc of `semanticEquals` says: `returns true when two expressions
will always compute the same result`. So I think they should be both null or
both not null if they are `semanticEquals`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
