Github user MLnick commented on a diff in the pull request:
https://github.com/apache/spark/pull/12207#discussion_r59160367
--- Diff: python/pyspark/sql/dataframe.py ---
@@ -1181,18 +1181,26 @@ def approxQuantile(self, col, probabilities,
relativeError):
Space-efficient Online Computation of Quantile Summaries]]
by Greenwald and Khanna.
- :param col: the name of the numerical column
+ :param cols: str, list.
+ The name(s) of the numerical column(s). Can be a string of the
name
--- End diff --
I think we can simplify this comment to: `Can be a single column name, or a
list of names for multiple columns`. I think it's clear from the specified
types that it's a string name or a list of string names.
(we mention in the method doc that it operates on numerical columns, we
don't need to repeat that).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
