Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/12263#discussion_r59258723
--- Diff:
examples/src/main/scala/org/apache/spark/examples/mllib/AbstractParams.scala ---
@@ -38,7 +38,7 @@ abstract class AbstractParams[T: TypeTag] {
*/
override def toString: String = {
val tpe = tag.tpe
- val allAccessors = tpe.declarations.collect {
+ val allAccessors = tpe.decls.collect {
--- End diff --
Yes, so I also took a look at this back when I was doing my initial
cleanup, there isn't an easy way to suppress deprecation warnings in Scala like
these ones (the answer from the Scala people seem to be either "you can't" or
"you could write a compiler plugin" which isn't a feasible option).
We should definitely do this once we get rid of Scala 2.10 (I created
https://issues.apache.org/jira/browse/SPARK-14417 to remind us to do the
cleanup once 2.10 is dead).
Personally I think the opportunity to get cleanup using these deprecated
APIs without version specific code is maybe part of a good reason why we should
consider removing 2.10 support, but that is being discussed more on the mailing
list.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
