Github user bomeng commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12314#discussion_r59314286
  
    --- Diff: 
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
    @@ -66,8 +65,7 @@ private[spark] class HiveExternalCatalog(client: 
HiveClient) extends ExternalCat
         try {
           body
         } catch {
    -      case e: NoSuchItemException =>
    -        throw new AnalysisException(e.getMessage)
    +      case e: AnalysisException => throw new 
AnalysisException(e.getMessage)
    --- End diff --
    
    I am open to either way. The original code is to catch 
`NoSuchItemException` and throw `AnalysisException`, which I did not want to 
change any logic in this patch. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to