GitHub user dongjoon-hyun opened a pull request:
https://github.com/apache/spark/pull/12340
[SPARK-14580][SQL] Hive IfCoercion should preserve predicate.
## What changes were proposed in this pull request?
Currently, `HiveTypeCoercion.IfCoercion` removes all predicates whose
return-type are null. However, some UDFs need evaluations because they are
designed to throw exceptions.
**Hive**
```
hive> select if(assert_true(false),2,3);
OK
Failed with exception
java.io.IOException:org.apache.hadoop.hive.ql.metadata.HiveException:
ASSERT_TRUE(): assertion failed.
```
This PR fixes that to preserve the predicates.
**Before**
```
scala> sql("select if(assert_true(false),2,3)").head
res2: org.apache.spark.sql.Row = [3]
```
**After**
```
scala> sql("select if(assert_true(false),2,3)").head
... ASSERT_TRUE ...
```
## How was this patch tested?
Pass the Jenkins tests (including a new testcase in `HivePlanTest`)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dongjoon-hyun/spark SPARK-14580
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/12340.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #12340
----
commit 938334ac236f1854da95a756ae0c97c15cb70b3c
Author: Dongjoon Hyun <dongj...@apache.org>
Date: 2016-04-12T17:23:09Z
[SPARK-14580][SQL] Hive IfCoercion should preserve predicate.
```
hive> select if(assert_true(false),2,3);
OK
Failed with exception
java.io.IOException:org.apache.hadoop.hive.ql.metadata.HiveException:
ASSERT_TRUE(): assertion failed.
```
**Before**
```
scala> sql("select if(assert_true(false),2,3)").head
res2: org.apache.spark.sql.Row = [3]
```
**After**
```
scala> sql("select if(assert_true(false),2,3)").head
... ASSERT_TRUE ...
```
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
