Github user vanzin commented on the pull request:
https://github.com/apache/spark/pull/12334#issuecomment-209258675
Overall looks ok, just have a few minor questions:
- now there's a single, unversioned "spark-parent" regardless of which
Scala version you're using; did you make sure that compiling an app against
Spark/2.10 using a spark-parent pom published by the 2.11 build doesn't
inadvertently cause any 2.11-specific things to leak out?
- similarly, I assume there will be no issues while deploying artifacts to
maven, since the 2.10 and 2.11 builds will now generate duplicate artifacts.
- regarding not supporting cross builds for Spark, is that really something
we don't want to support? I've hacked together something (non-Spark-related) in
maven to allow cross-compiling in the same build, and I think that if we're
going to support multiple versions of Scala, that might be a good thing to have
in Spark; it's not unusual for the 2.10 build to be broken these days because
it's not exercised by the PR builders.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
