GitHub user sethah opened a pull request:

    https://github.com/apache/spark/pull/12374

    [SPARK-14610][ML] Remove superfluous split for continuous features in 
decision tree training

    ## What changes were proposed in this pull request?
    
    A nonsensical split is produced from method 
`findSplitsForContinuousFeature` for decision trees. This PR removes the 
superfluous split and updates unit tests accordingly. Additionally, an 
assertion to check that the number of found splits is `> 0` is removed, and 
instead features with zero possible splits are ignored. 
    
    ## How was this patch tested?
    
    A unit test was added to check that finding splits for a constant feature 
produces an empty array.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sethah/spark SPARK-14610

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/12374.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #12374
    
----
commit d721933958ba31f4d67dbec2b2372568b1d0d8a8
Author: sethah <[email protected]>
Date:   2016-04-13T23:27:26Z

    remove extra split for continuous features

commit 98c31e9ca53de248c582cfd21959568912d8939e
Author: sethah <[email protected]>
Date:   2016-04-13T23:34:08Z

    cleanup

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to