Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/12081#discussion_r59651172
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -18,24 +18,39 @@
package org.apache.spark.sql.hive.execution
import org.apache.hadoop.fs.Path
+import org.scalatest.BeforeAndAfterEach
import org.apache.spark.sql.{AnalysisException, QueryTest, SaveMode}
-import org.apache.spark.sql.catalyst.catalog.CatalogTableType
+import org.apache.spark.sql.catalyst.catalog.{CatalogDatabase,
CatalogTableType}
import org.apache.spark.sql.catalyst.TableIdentifier
import org.apache.spark.sql.hive.test.TestHiveSingleton
import org.apache.spark.sql.internal.SQLConf
import org.apache.spark.sql.test.SQLTestUtils
-class HiveDDLSuite extends QueryTest with SQLTestUtils with
TestHiveSingleton {
+class HiveDDLSuite
+ extends QueryTest with SQLTestUtils with TestHiveSingleton with
BeforeAndAfterEach {
import hiveContext.implicits._
+ override def afterEach(): Unit = {
+ try {
+ // drop all databases, tables and functions after each test
+ sqlContext.sessionState.catalog.reset()
+ } finally {
+ super.afterEach()
+ }
+ }
// check if the directory for recording the data of the table exists.
- private def tableDirectoryExists(tableIdentifier: TableIdentifier):
Boolean = {
+ private def tableDirectoryExists(
+ tableIdentifier: TableIdentifier,
+ dbPath: Option[String] = None): Boolean = {
val expectedTablePath =
-
hiveContext.sessionState.catalog.hiveDefaultTableFilePath(tableIdentifier)
- val filesystemPath = new Path(expectedTablePath)
- val fs = filesystemPath.getFileSystem(sparkContext.hadoopConfiguration)
- fs.exists(filesystemPath)
+ if (dbPath.isEmpty) {
+ new Path
(hiveContext.sessionState.catalog.hiveDefaultTableFilePath(tableIdentifier))
--- End diff --
Thanks! Do it now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
