Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12341#discussion_r59682240
--- Diff: core/src/main/scala/org/apache/spark/ui/WebUI.scala ---
@@ -133,26 +133,28 @@ private[spark] abstract class WebUI(
/** Bind to the HTTP server behind this web interface. */
def bind() {
- assert(!serverInfo.isDefined, "Attempted to bind %s more than
once!".format(className))
+ assert(!serverInfo.isDefined, s"Attempted to bind $className more than
once!")
try {
- var host = Option(conf.getenv("SPARK_LOCAL_IP")).getOrElse("0.0.0.0")
+ val host = Option(conf.getenv("SPARK_LOCAL_IP")).getOrElse("0.0.0.0")
serverInfo = Some(startJettyServer(host, port, sslOptions, handlers,
conf, name))
- logInfo("Bound %s to %s, and started at
http://%s:%d".format(className, host,
- publicHostName, boundPort))
+ logInfo(s"Bound $className to $host, and started at $webUrl")
} catch {
case e: Exception =>
- logError("Failed to bind %s".format(className), e)
+ logError(s"Failed to bind $className", e)
System.exit(1)
}
}
+ /** Return the url of web interface. Only valid after bind(). */
+ def webUrl: String = s"http://$publicHostName:$boundPort";
--- End diff --
Same, doesn't seem like this is used anywhere except a few lines above, so
probably doesn't need to be a method?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
