GitHub user lw-lin opened a pull request:
https://github.com/apache/spark/pull/12389
[SPARK-14630][Build][Core][SQL][Streaming] Code style: public abstract
methods should have explicit return types
## What changes were proposed in this pull request?
Currently many public abstract methods (in abstract classes as well as
traits) don't declare return types explicitly, such as in
[o.a.s.streaming.dstream.InputDStream](https://github.com/apache/spark/blob/master/streaming/src/main/scala/org/apache/spark/streaming/dstream/InputDStream.scala#L110):
```scala
def start() // should be: def start(): Unit
def stop() // should be: def stop(): Unit
```
These methods exist in core, sql, streaming, and this PR fixes them.
## How was this patch tested?
N/A
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lw-lin/spark public-abstract-methods
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/12389.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #12389
----
commit b2d36b25eb2cec3c602f42bd18dc504b0dbc3935
Author: Liwei Lin <[email protected]>
Date: 2016-04-14T09:36:48Z
fix for cor
commit 60791a1bbdcb48fffcd2dd73e1e943c89dd0bf5a
Author: Liwei Lin <[email protected]>
Date: 2016-04-14T09:37:53Z
fix for sql
commit d3d83b046fa9c6da6cf99ecdf3d3b37fead169f9
Author: Liwei Lin <[email protected]>
Date: 2016-04-14T09:38:15Z
fix for streaming
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
