GitHub user lw-lin opened a pull request:
https://github.com/apache/spark/pull/12396
[WIP][SPARK-14629][SPARK-14630] Add support for custom scala style rules &
Add rule PublicAbstractMethodsHaveTypeChecker
## What changes were proposed in this pull request?
- [ ] automatically build and install custom rules
- [x] added a custom rule `PublicAbstractMethodsHaveTypeChecker`
implementation, which would ensure public abstract methods have explicit return
types
## How was this patch tested?
the list of errors found by this `PublicAbstractMethodsHaveTypeChecker`
rule is here: https://github.com/apache/spark/pull/12389/files
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lw-lin/spark custom-rules
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/12396.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #12396
----
commit c7a8086f4b1590f7eb3ba0e31bc10650c5c6b418
Author: Liwei Lin <[email protected]>
Date: 2016-04-14T12:38:31Z
add the PublicAbstractMethodsHaveTypeChecker rule impl
commit 3ef53ac24f3330621300c00e4282d4e525c21d94
Author: Liwei Lin <[email protected]>
Date: 2016-04-14T12:40:47Z
add PublicAbstractMethodsHaveTypeChecker rule in scalastyle-config.xml
commit fb54cde4b656c0b45e64a1bed98a6b8cc6b61564
Author: Liwei Lin <[email protected]>
Date: 2016-04-14T12:41:06Z
add maven dependency
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
