Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12153#discussion_r59733621
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/sources/hadoopFsRelationSuites.scala
---
@@ -668,6 +671,42 @@ abstract class HadoopFsRelationTest extends QueryTest
with SQLTestUtils with Tes
df.write.format(dataSourceName).partitionBy("c", "d",
"e").saveAsTable("t")
}
}
+
+ test("Locality support for FileScanRDD") {
--- End diff --
How about we add the following test cases?
* Every partition of the FileScanRDD has a single file.
* There are some large files. So, there are some partitions and every such
a partition has a part of a file.
* If we are going to pick the top K locations that host the largest amount
of data, let's also add tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
