Github user sethah commented on the pull request:
https://github.com/apache/spark/pull/9008#issuecomment-210002149
@holdenk Thanks for the feedback. Upon some further thought, I think that
a.) We need to compute the statistics needed for both `minInstancesPerNode` and
`minWeightFractionPerNode` and b.) it will not be too hard to compute them both
and will not add a ton of extra memory overhead. Selectively computing one or
the other could get complicated very quickly.
I am going to have a PR for this ready soon, which will incorporate changes
submitted in this PR. I created two JIRAs for issues that I encountered when
preparing this PR and submitted patches for each. They are:
* [SPARK-14610](https://issues.apache.org/jira/browse/SPARK-14610) - [PR
12374](https://github.com/apache/spark/pull/12374)
* [SPARK-14599](https://issues.apache.org/jira/browse/SPARK-14599) - [PR
12370](https://github.com/apache/spark/pull/12370)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
