Github user joan38 commented on a diff in the pull request:
https://github.com/apache/spark/pull/12157#discussion_r59771079
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/literals.scala
---
@@ -169,6 +170,8 @@ case class Literal protected (value: Any, dataType:
DataType)
override def toString: String = if (value != null) value.toString else
"null"
+ override def hashCode(): Int = 42 * dataType.hashCode() +
Objects.hashCode(value)
--- End diff --
Make sense.
I can't see any rules like that
http://www.scalastyle.org/rules-0.8.0.html#org_scalastyle_scalariform_EqualsHashCodeChecker
and I think that is understandable as hashCode and equals should really be
defined together.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
