Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/1673#discussion_r15628159
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/DecisionTree.scala ---
@@ -612,27 +615,31 @@ object DecisionTree extends Serializable with Logging
{
agg(aggIndex + labelInt) = agg(aggIndex + labelInt) + 1
}
- def updateBinForUnorderedFeature(nodeIndex: Int, featureIndex: Int,
arr: Array[Double],
- label: Double, agg: Array[Double], rightChildShift: Int) = {
+ def updateBinForUnorderedFeature(
+ nodeIndex: Int,
+ featureIndex: Int,
+ arr: Array[Double],
+ label: Double,
+ agg: Array[Double],
+ rightChildShift: Int) = {
--- End diff --
Your comments in the PR description is very helpful to understand the code
the indexing of `agg`. Do you mind copying them here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
