Github user dilipbiswal commented on the pull request:
https://github.com/apache/spark/pull/12222#issuecomment-210294481
@andrewor14 Thank you for a detailed review. I have implemented your
comments. A few points/questions.
1) Currently InMemoryCatalog does not make use of partiton spec. If it is
ok with you, can i work on it as a follow up ?
2) In listPartitions API , the optional partition spec has a default value
to avoid changing the callers. Is that a ok thing to do ? If its not, i will
change the callers to pass None where applicable.
Thanks again for your time and help !!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
