Github user peterableda commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12395#discussion_r59849405
  
    --- Diff: 
core/src/main/scala/org/apache/spark/memory/StaticMemoryManager.scala ---
    @@ -104,6 +104,8 @@ private[spark] class StaticMemoryManager(
     
     private[spark] object StaticMemoryManager {
     
    +  private val MIN_MEMORY_BYTES = 450 * 1024 * 1024
    --- End diff --
    
    How about a trait containing the **RESERVED_SYSTEM_MEMORY_BYTES** in the 
https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/memory/MemoryManager.scala
 file? 
    Both the **StaticMemoryManager** and the **UnifiedMemoryManager** objects 
could extend this trait and reference the constant.  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to