Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/12422#issuecomment-210591482
The original design was to allow us to not have to transfer it if the user
was using the default stop words, but overall this change looks good me (I'm
not sure I'd call it a bug but that a minor point). That being said the
stopword list is small enough this optimization isn't important and this
simplifies the work going on in https://github.com/apache/spark/pull/11939 so
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
