Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/12388#discussion_r59923261
--- Diff:
core/src/main/scala/org/apache/spark/ui/jobs/JobProgressListener.scala ---
@@ -434,50 +434,50 @@ class JobProgressListener(conf: SparkConf) extends
SparkListener with Logging {
val execSummary = stageData.executorSummary.getOrElseUpdate(execId,
new ExecutorSummary)
val shuffleWriteDelta =
- (taskMetrics.shuffleWriteMetrics.map(_.bytesWritten).getOrElse(0L)
- -
oldMetrics.flatMap(_.shuffleWriteMetrics).map(_.bytesWritten).getOrElse(0L))
+ taskMetrics.shuffleWriteMetrics.bytesWritten
+ - oldMetrics.map(_.shuffleWriteMetrics.bytesWritten).getOrElse(0L)
stageData.shuffleWriteBytes += shuffleWriteDelta
execSummary.shuffleWrite += shuffleWriteDelta
val shuffleWriteRecordsDelta =
- (taskMetrics.shuffleWriteMetrics.map(_.recordsWritten).getOrElse(0L)
- -
oldMetrics.flatMap(_.shuffleWriteMetrics).map(_.recordsWritten).getOrElse(0L))
+ taskMetrics.shuffleWriteMetrics.recordsWritten
+ -
oldMetrics.map(_.shuffleWriteMetrics.recordsWritten).getOrElse(0L)
stageData.shuffleWriteRecords += shuffleWriteRecordsDelta
execSummary.shuffleWriteRecords += shuffleWriteRecordsDelta
val shuffleReadDelta =
- (taskMetrics.shuffleReadMetrics.map(_.totalBytesRead).getOrElse(0L)
- -
oldMetrics.flatMap(_.shuffleReadMetrics).map(_.totalBytesRead).getOrElse(0L))
+ taskMetrics.shuffleReadMetrics.totalBytesRead
+ - oldMetrics.map(_.shuffleReadMetrics.totalBytesRead).getOrElse(0L)
--- End diff --
oh come on... no one likes mandatory semi-colons right? ð
Does this case not even generate a warning? I guess it doesn't know your
`.map` is a pure expression.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
