Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/1636#issuecomment-50729675
@chutium Michael is right, `NullableColumnBuilderSuite` doesn't call
`ColumnBuilder.apply`, thus it always passes. But adding `TIMESTAMP` still
makes sense. Actually, would you mind to add `TIMESTAMP` to
`NullableColumnAccessorSuite` too? These two test suites are structurally
similar. Thanks!
To add a valid test case for this PR, I'd recommend
`InMemoryColumnarQuerySuite`. You may refer to [my comments in
SPARK-2729](https://issues.apache.org/jira/browse/SPARK-2729?focusedCommentId=14080624&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14080624)
to write this test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
