GitHub user jasoncl opened a pull request:

    https://github.com/apache/spark/pull/12428

    [Spark-14564] [ML] [MLlib] [PySpark] Python Word2Vec missing setWindowSize 
method

    ## What changes were proposed in this pull request?
    Added windowSize getter/setter to ML/MLlib
    
    
    ## How was this patch tested?
    Added test cases in tests.py under both ML and MLlib
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jasoncl/spark SPARK-14564

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/12428.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #12428
    
----
commit 1d9ac29f7c5daeabb0abf4c605dc0671f389e91c
Author: Jason Lee <[email protected]>
Date:   2016-04-12T19:58:48Z

    added windowSize setter and getter for python word2Vec

commit 1e373aae7d7931ed24d61b9f3a0268f46adf76c2
Author: Jason Lee <[email protected]>
Date:   2016-04-14T18:01:26Z

    added windowSize test case

commit 859dd1b2bb4d6a9c4339c7fd628eab4dc53ea980
Author: Jason Lee <[email protected]>
Date:   2016-04-14T18:02:56Z

    added windowSize test case

commit 2f757c837377a0b24ad689ee139d20a6bfe92451
Author: Jason Lee <[email protected]>
Date:   2016-04-14T18:35:16Z

    added assertEqual for windowSize test case

commit 2614fe89a6cf110f33a3cb3862be36e15742873d
Author: Jason Lee <[email protected]>
Date:   2016-04-14T20:20:29Z

    set correct version

commit 83bbdc10e073988b0664d29ff0f73fe7d2629e4b
Author: Jason Lee <[email protected]>
Date:   2016-04-14T23:07:44Z

    added a test case in ml

commit 417a7d48e3167bed319b8f2472971b61b4024590
Author: Jason Lee <[email protected]>
Date:   2016-04-15T21:33:54Z

    rephrase doc for windowSize

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to