Github user ericl commented on a diff in the pull request:
https://github.com/apache/spark/pull/12425#discussion_r59948041
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/Sort.scala
---
@@ -87,10 +89,12 @@ case class Sort(
// Remember spill data size of this task before execute this
operator so that we can
// figure out how many bytes we spilled for this operator.
val spillSizeBefore = metrics.memoryBytesSpilled
+ val beforeSort = System.currentTimeMillis()
--- End diff --
Should we use nanoTime() instead of currentTimeMillis(), which is not
guaranteed to be monotonic?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
