Github user markgrover commented on the pull request:
https://github.com/apache/spark/pull/11863#issuecomment-210696664
Thanks for this, @koeninger! This is looking really good. I have made some
comments inline.
I noticed that there wasn't a new example, a new KafkaUtils, python support
or documentation. So, we should take care of those too.
Also, I'd personally prefer a different name than kafka-beta, because the
new consumer API will become GA some day and I would rather not have us rename
the project then and break everyone. I would personally prefer calling it some
thing like kafka-newapi (or something else, it's not that important). We can
doc that this subproject is beta quality but as time goes and the subproject
and kafka's new consumer API matures, we don't have to rename, just update the
docs.
And, I would definitely like to help out with the work you have started
here. Whether it's implementing some of the comments (if you agree with them),
or the left over things that I listed out earlier. Let me know what you think.
Thanks again for working on this!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
