Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12450#discussion_r59982497
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/FileStreamSource.scala
---
@@ -39,7 +39,7 @@ class FileStreamSource(
providerName: String,
dataFrameBuilder: Array[String] => DataFrame) extends Source with
Logging {
- private val fs =
FileSystem.get(sqlContext.sparkContext.hadoopConfiguration)
+ private val fs = new
Path(path).getFileSystem(sqlContext.sparkContext.hadoopConfiguration)
--- End diff --
All LGTM pending tests. I suppose this could even be fetched in the one
place it's used later during the method call rather than hold on to a
reference, but, I can't recall a specific reason it's bad to hold onto a
FileSystem handle, so, leave it as you've done I think.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
