Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/12454#discussion_r60000631
--- Diff:
examples/src/main/scala/org/apache/spark/examples/ml/TfIdfExample.scala ---
@@ -20,7 +20,7 @@ package org.apache.spark.examples.ml
import org.apache.spark.{SparkConf, SparkContext}
// $example on$
-import org.apache.spark.ml.feature.{HashingTF, IDF, Tokenizer}
--- End diff --
Why did we add CountVectorizer as an import here and not in
JavaTfIdfExample? Since we aren't referencing it in code in either I'd probably
leave it out of both personally (but either way consistency would be best).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
