Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12462#discussion_r60001921
  
    --- Diff: 
core/src/test/resources/HistoryServerExpectations/application_list_json_expectation.json
 ---
    @@ -2,108 +2,108 @@
       "id" : "local-1430917381534",
       "name" : "Spark shell",
       "attempts" : [ {
    -    "startTimeEpoch" : 1430917380893,
    -    "endTimeEpoch" : 1430917391398,
    -    "lastUpdatedEpoch" : 0,
         "startTime" : "2015-05-06T13:03:00.893GMT",
         "endTime" : "2015-05-06T13:03:11.398GMT",
         "lastUpdated" : "",
         "duration" : 10505,
         "sparkUser" : "irashid",
    -    "completed" : true
    +    "completed" : true,
    +    "startTimeEpoch" : 1430917380893,
    +    "endTimeEpoch" : 1430917391398,
    +    "lastUpdatedEpoch" : 0
       } ]
     }, {
       "id" : "local-1430917381535",
       "name" : "Spark shell",
       "attempts" : [ {
         "attemptId" : "2",
    -    "startTimeEpoch" : 1430917380893,
    -    "endTimeEpoch" : 1430917380950,
    -    "lastUpdatedEpoch" : 0,
         "startTime" : "2015-05-06T13:03:00.893GMT",
         "endTime" : "2015-05-06T13:03:00.950GMT",
         "lastUpdated" : "",
         "duration" : 57,
         "sparkUser" : "irashid",
    -    "completed" : true
    +    "completed" : true,
    +    "startTimeEpoch" : 1430917380893,
    +    "endTimeEpoch" : 1430917380950,
    +    "lastUpdatedEpoch" : 0
       }, {
         "attemptId" : "1",
    -    "startTimeEpoch" : 1430917380880,
    -    "endTimeEpoch" : 1430917380890,
    -    "lastUpdatedEpoch" : 0,
    --- End diff --
    
    When I re-generate the gold answer, these 3 fields are moved to the last. 
It seems that when we introduce these 3 fields at 
https://github.com/apache/spark/pull/11326, we didn't re-generate gold answer, 
but update the answer files manually.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to