Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12105#discussion_r60020044
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -391,21 +395,24 @@ abstract class UnixTime extends BinaryExpression with
ExpectsInputTypes {
case StringType if right.foldable =>
val sdf = classOf[SimpleDateFormat].getName
val fString = if (constFormat == null) null else
constFormat.toString
- val formatter = ctx.freshName("formatter")
if (fString == null) {
s"""
boolean ${ev.isNull} = true;
${ctx.javaType(dataType)} ${ev.value} =
${ctx.defaultValue(dataType)};
"""
} else {
+ val formatter = ctx.freshName("formatter")
+ ctx.addMutableState(sdf, formatter, s"""$formatter = null;""")
val eval1 = left.gen(ctx)
s"""
${eval1.code}
boolean ${ev.isNull} = ${eval1.isNull};
${ctx.javaType(dataType)} ${ev.value} =
${ctx.defaultValue(dataType)};
if (!${ev.isNull}) {
try {
- $sdf $formatter = new $sdf("$fString");
+ if ($formatter == null) {
+ $formatter = new $sdf("$fString");
--- End diff --
Hm, but doesn't this generated code then need the same guards as above? I
think I may not know enough to review this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
