Github user squito commented on the pull request:
https://github.com/apache/spark/pull/12369#issuecomment-211413125
Thanks for the review @davies. I actually just found out about another
workload failure even with this patch -- not sure if its related or not, but
I'll look into today and will update, so lets hold off on merging for the
moment in any case.
@lianhuiwang sorry I wasn't aware of your PR earlier. I totally agree that
it makes more sense to have Spillables actually spill when requested by a
MemoryConsumer. However as that change is more invasive and risky, I still
think it makes sense to put this in for now as a safe, easy fix for now. If
that later patch completely removes the need for this, that would be fantastic.
I'll take a look at your patch as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
