Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/12439#issuecomment-211474265
Nice PR, this looks good except for the 1 nit I commented on.
After this PR, I believe we will have full Python coverage for persistence!
I'd like to do something of an integration test for persistence in ml/tests.py
in the "PersistenceTest" suite. I just made a JIRA:
[https://issues.apache.org/jira/browse/SPARK-14706]. Would you be interested
in working on that one?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
