Github user rdblue commented on a diff in the pull request:
https://github.com/apache/spark/pull/12437#discussion_r60122812
--- Diff:
core/src/main/scala/org/apache/spark/ui/scope/RDDOperationGraph.scala ---
@@ -72,6 +72,22 @@ private[ui] class RDDOperationCluster(val id: String,
private var _name: String)
def getCachedNodes: Seq[RDDOperationNode] = {
_childNodes.filter(_.cached) ++
_childClusters.flatMap(_.getCachedNodes)
}
+
+ def canEqual(other: Any): Boolean =
other.isInstanceOf[RDDOperationCluster]
+
+ override def equals(other: Any): Boolean = other match {
+ case that: RDDOperationCluster =>
+ (that canEqual this) &&
+ _childClusters == that._childClusters &&
+ id == that.id &&
+ _name == that._name
+ case _ => false
+ }
+
+ override def hashCode(): Int = {
+ val state = Seq(_childClusters, id, _name)
+ state.map(_.hashCode()).foldLeft(0)((a, b) => 31 * a + b)
--- End diff --
I updated this to use `java.util.Objects.hashCode`, assuming you meant that
and not the Guava Objects.hashCode. I opted for this form because it was fairly
concise and there doesn't seem to be an established common practice in the rest
of the codebase from a quick search. Just let me know what the consensus on
this is and I'll change it. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
