Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11865#discussion_r60129541
  
    --- Diff: core/src/main/scala/org/apache/spark/rdd/CoalescedRDD.scala ---
    @@ -70,21 +70,24 @@ private[spark] case class CoalescedRDDPartition(
      * parent partitions
      * @param prev RDD to be coalesced
      * @param maxPartitions number of desired partitions in the coalesced RDD 
(must be positive)
    - * @param balanceSlack used to trade-off balance and locality. 1.0 is all 
locality, 0 is all balance
    + * @param partitionCoalescer [[PartitionCoalescer]] implementation to use 
for coalescing
      */
     private[spark] class CoalescedRDD[T: ClassTag](
         @transient var prev: RDD[T],
         maxPartitions: Int,
    -    balanceSlack: Double = 0.10)
    +    partitionCoalescer: Option[PartitionCoalescer] = None)
       extends RDD[T](prev.context, Nil) {  // Nil since we implement 
getDependencies
     
       require(maxPartitions > 0 || maxPartitions == prev.partitions.length,
         s"Number of partitions ($maxPartitions) must be positive.")
     
    +  // used to trade-off balance and locality. 1.0 is all locality, 0 is all 
balance
    +  val balanceSlack: Double = 0.10
    --- End diff --
    
    we don't need a val here do we?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to