Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12179#discussion_r60154140
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
 ---
    @@ -288,15 +288,25 @@ case class DataSource(
     
             val fileCatalog: FileCatalog =
               new HDFSFileCatalog(sqlContext, options, globbedPaths, 
partitionSchema)
    -        val dataSchema = userSpecifiedSchema.orElse {
    +
    +        val dataSchema = userSpecifiedSchema.map { schema =>
    +          val equality =
    +            if (sqlContext.conf.caseSensitiveAnalysis) {
    +              
org.apache.spark.sql.catalyst.analysis.caseSensitiveResolution
    +            } else {
    +              
org.apache.spark.sql.catalyst.analysis.caseInsensitiveResolution
    +            }
    +
    +          StructType(schema.filterNot(f => 
partitionColumns.exists(equality(_, f.name))))
    +        }.orElse {
    --- End diff --
    
    I'd like to go with changing the semantic. It only breaks runtime behavior 
when there are partitioned columns in physical file, which doesn't happen very 
often


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to