Github user dongjoon-hyun commented on the pull request:
https://github.com/apache/spark/pull/12353#issuecomment-211726421
Hi, @rxin . Now, the PR is updated in the following ways.
1. `CaseWhen` split into three classes:
- `CaseWhenBase`: abstract base class
- `CaseWhen`: codegen fallback
- `CaseWhenCodegen`: codegen
1. `OptimizeCodegen` optimizer added:
- Replace `CaseWhen` into `CaseWhenCodegen` if branches.size <
conf.maxCasesBranches.
1. `CodegenConf` is removed and `CatalystConf` has `maxCasesBranches`.
(`SQLConf` does not changed.)
- Since `Optimizer` uses that configuration, I think `CatalystConf`
becomes more proper place.
How do you think about item 3?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
