Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12433#discussion_r60180666
  
    --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala 
---
    @@ -260,7 +260,12 @@ private[spark] class BlockManager(
       def waitForAsyncReregister(): Unit = {
         val task = asyncReregisterTask
         if (task != null) {
    -      Await.ready(task, Duration.Inf)
    +      try {
    +        Await.ready(task, Duration.Inf)
    --- End diff --
    
    According to the Scaladoc (and actual usages), it looks like this 
particular `waitForAsyncReregister` method is only used in test code and I'm 
guessing that it's probably called from within an interrupt-based timeout block.
    
    As for the other usages, we'd have to consider them on a case-by-case basis.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to