Github user BenFradet commented on a diff in the pull request:
https://github.com/apache/spark/pull/12467#discussion_r60250070
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/RFormulaSuite.scala ---
@@ -290,4 +291,18 @@ class RFormulaSuite extends SparkFunSuite with
MLlibTestSparkContext with Defaul
val newModel = testDefaultReadWrite(model)
checkModelData(model, newModel)
}
+
+ test("should support all NumericType labels") {
--- End diff --
It'd work expect for the expected exception when dealing with a dataframe
containing string labels because the label column gets indexed by RFormula's
`fit`.
Consequently, an exception is thrown by `StringIndexer`.
What I could do is add a `validateSchema` to RFormula (called at the
beginiing of the `fit` method) checking that the label column is of numeric
type, then I could use `MLTestingUtils.checkNumericTypes`.
What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
