Github user tdas commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1434#discussion_r15670918
  
    --- Diff: assembly/pom.xml ---
    @@ -186,6 +186,16 @@
           </dependencies>
         </profile>
         <profile>
    +      <id>kinesis-asl</id>
    +      <dependencies>
    +        <dependency>
    +          <groupId>org.apache.spark</groupId>
    +          <artifactId>kinesis-asl_${scala.binary.version}</artifactId>
    --- End diff --
    
    The artifact id should `spark-streaming-kinesis-asl` because the published 
maven dependencies should have spark (to make it clear that its related to 
Spark).
    The profile id can be `kinesis-asl` as it is used only at Spark compile 
time when the person is already dealing with spark. 
    Sorry if this wasnt clear.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to