Github user shivaram commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10480#discussion_r60273460
  
    --- Diff: core/src/main/scala/org/apache/spark/api/r/SerDe.scala ---
    @@ -355,6 +355,13 @@ private[spark] object SerDe {
               writeInt(dos, v.length)
               v.foreach(elem => writeObject(dos, elem))
     
    +        // Handle Properties
    --- End diff --
    
    Thanks @felixcheung for summarizing the options. I was trying to judge how 
frequently we use `java.util.Properties` in the Spark DataFrame codebase and it 
looks like JDBC support is the only use case that is using this. That said if 
having support in SerDe makes the integration much easier I think we can go 
along this route. As @frreiss said, java.util.Properties is a pretty common 
data structure, so this could be useful in the future.
    
    Overall I think the current option is fine by me


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to