Github user JoshRosen commented on the pull request:
https://github.com/apache/spark/pull/1598#issuecomment-50821078
This patch looks pretty good and contains some great refactorings. I like
how you changed the Python data types inherit from a common `DataType` base
class; the cleanup in `_parse_datatype_string` is good, too.
I left a couple of comments on parts of the Scala code. My only concern
has to do with the detection of batching in pythonToJava. Aside from that, the
rest of this PR looks fine to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
