Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/12498#discussion_r60283077
--- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/HashingTF.scala
---
@@ -63,7 +63,18 @@ class HashingTF(override val uid: String)
"This is useful for discrete probabilistic models that model binary
events rather " +
"than integer counts")
- setDefault(numFeatures -> (1 << 18), binary -> false)
+ /**
+ * The hash algorithm used when mapping term to integer.
+ * Supported options: "murmur3" and "native".
+ * (Default = "murmur3")
+ * @group param
+ */
+ val hashAlgorithm = new Param[String](this, "hashAlgorithm", "The hash
algorithm used when " +
+ "mapping term to integer. Supported options: murmur3(default) and
native.",
--- End diff --
Instead of hard coding the supported options you could use
`${feature.HashingTF.supportedHashAlgorithms.mkString(",")}`. This is done in
other params, like
[here](https://github.com/apache/spark/blob/master/mllib/src/main/scala/org/apache/spark/ml/tree/treeParams.scala#L192).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
