Github user zsxwing commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12435#discussion_r60307237
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
    @@ -443,6 +444,27 @@ object SQLConf {
         .booleanConf
         .createWithDefault(false)
     
    +  val FILE_SINK_LOG_DELETION = 
SQLConfigBuilder("spark.sql.streaming.fileSink.log.deletion")
    +    .internal()
    +    .doc("Whether to delete the expired log files in file stream sink.")
    +    .booleanConf
    +    .createWithDefault(true)
    +
    +  val FILE_SINK_LOG_COMPACT_INTERVAL =
    +    SQLConfigBuilder("spark.sql.streaming.fileSink.log.compactInterval")
    +      .internal()
    +      .doc("Number of log files after which all the previous files " +
    +        "are compacted into the next log file.")
    +      .intConf
    +      .createWithDefault(10)
    +
    +  val FILE_SINK_LOG_CLEANUP_DELAY =
    +    SQLConfigBuilder("spark.sql.streaming.fileSink.log.cleanupDelay")
    +      .internal()
    +      .doc("How long in milliseconds a file is guaranteed to be visible 
for all readers.")
    --- End diff --
    
    In addition, old Hadoop's `open` method doesn't guarantee to throw 
FileNotFoundException. E.g., 
https://github.com/apache/hadoop/blob/release-2.4.0/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/s3/S3FileSystem.java#L181


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to