Github user hvanhovell commented on the pull request:
https://github.com/apache/spark/pull/12397#issuecomment-212350772
@robbinspg could you post the benchmark results anyway? I would be nice to
have a fact based discussion. I am particularly curious what the results of
this approach are, because I would have put my money on dead-code elimination
instead of subclassing performance wise.
I am also wondering if putting the Platform dependent code in static
methods would not yield better results (Hotspot should only have to perform
deadcode elimination once).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
