Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/12520#discussion_r60378039
--- Diff:
common/unsafe/src/main/java/org/apache/spark/unsafe/types/CalendarInterval.java
---
@@ -318,7 +318,7 @@ public String toString() {
private void appendUnit(StringBuilder sb, long value, String unit) {
if (value != 0) {
- sb.append(" " + value + " " + unit + "s");
+ sb.append(" ").append(value).append(" ").append(unit).append("s");
--- End diff --
Super nit, but if you're optimizing this, append characters instead of
single-character strings: `'s'` vs `"s"`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
